From d8a757e573d9b26d691f404a8ecbd30a5660ed8a Mon Sep 17 00:00:00 2001 From: Marrub Date: Sat, 4 May 2019 02:43:11 -0400 Subject: [PATCH] flac2mp3: fix metadata not actually being copied (because it's piping through a wav) --- flac2mp3.sh | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/flac2mp3.sh b/flac2mp3.sh index 0b07bf9..cdd0079 100755 --- a/flac2mp3.sh +++ b/flac2mp3.sh @@ -1,15 +1,13 @@ fail() { echo "failed to process $f, exiting" - rm "$wav" exit 1 } for f in ./*.flac do - wav="$(basename "$f" .flac).wav" - flac -s -d "$f" - if (( $? )); then fail; fi - lame --quiet -V0 "$wav" - if (( $? )); then fail; fi + ffmpeg -i "$f" -q:a 0 -vn "$(basename "$f" .flac).mp3" + (( $? )) && fail echo "$f success" - rm "$f" "$wav" done + +read -ep "success. delete files? [yn] " YN +[[ ${YN,,} == y* ]] && rm ./*.flac