User model: give user settings getter methods better names; cache the settings queries.

app/models/user.rb

@@ -225,90 +225,94 @@ class User < ApplicationRecord
     save!
   end
 
-  def setting_larger_menus
+  def larger_menus?
-    settings.larger_menus || false
+    @larger_menus ||= (settings.larger_menus || false)
   end
 
-  def setting_larger_buttons
+  def larger_buttons?
-    settings.larger_buttons || false
+    @larger_buttons ||= (settings.larger_buttons || false)
   end
 
-  def setting_larger_drawer
+  def larger_drawer?
-    settings.larger_drawer || false
+    @larger_drawer ||= (settings.larger_drawer || false)
   end
 
-  def setting_remove_filtered
+  def remove_filtered?
-    settings.remove_filtered || false
+    @remove_filtered ||= (settings.remove_filtered || false)
   end
 
-  def setting_hide_replies_muted
+  def hide_replies_muted?
-    settings.hide_replies_muted || true
+    @hide_replies ||= (settings.hide_replies_muted || true)
   end
 
-  def setting_hide_replies_blocked
+  def hide_replies_of_blocked?
-    settings.hide_replies_blocked || true
+    @hide_replies_of_blocked ||= (settings.hide_replies_blocked || true)
   end
 
-  def setting_hide_replies_blocker
+  def hide_replies_of_blocker?
-    settings.hide_replies_blocker || true
+    @hide_replies_of_blocker ||= (settings.hide_replies_blocker || true)
   end
 
-  def setting_hide_mntions_muted
+  def hide_mentions_of_muted?
-    settings.hide_mntions_muted || true
+    @hide_mentions_of_muted ||= (settings.hide_mntions_muted || true)
   end
 
-  def setting_hide_mntions_blocked
+  def hide_mentions_of_blocked?
-    settings.hide_mntions_blocked || true
+    @hide_mentions_of_blocked ||= (settings.hide_mntions_blocked || true)
   end
 
-  def setting_hide_mntions_blocker
+  def hide_mentions_of_blocker?
-    settings.hide_mntions_blocker || true
+    @hide_mentions_of_blocker ||= (settings.hide_mntions_blocker || true)
   end
 
-  def setting_hide_mntions_packm8
+  def hide_mentions_outside_scope?
-    settings.hide_mntions_packm8 || true
+    @hide_mentions_outside_scope ||= (settings.hide_mntions_packm8 || true)
   end
 
-  def setting_gently_kobolds
+  def gently_kobolds?
-    settings.gently_kobolds || false
+    @gently_kobolds ||= (settings.gently_kobolds || false)
   end
 
-  def setting_user_is_kobold
+  def user_is_kobold?
-    settings.user_is_kobold || false
+    @user_is_kobold ||= (settings.user_is_kobold || false)
   end
 
-  def setting_hide_mascot
+  def hide_mascot?
-    settings.hide_mascot || false
+    @hide_mascop ||= (settings.hide_mascot || false)
   end
 
-  def setting_hide_interactions
+  def hide_interactions?
-    settings.hide_interactions || false
+    @hide_interactions ||= (settings.hide_interactions || false)
+  end
+
+  def default_local?
+    @default_local ||= (settings.default_local || false)
+  end
+
+  def always_local?
+    @always_local ||= (settings.always_local || false)
+  end
+
+  def rawr_federated?
+    @rawr_federated ||= (settings.rawr_federated || false)
+  end
+
+  def disable_color?
+    @disable_color ||= (settings.disable_color || false)
+  end
+
+  def hide_stats?
+    @hide_stats ||= (settings.hide_stats || false)
+  end
+
+  def hide_captions?
+    @hide_captions ||= (settings.hide_captions || false)
   end
 
   def setting_default_privacy
     settings.default_privacy || 'public'
   end
 
-  def setting_default_local
-    settings.default_local || false
-  end
-
-  def setting_always_local
-    settings.always_local || false
-  end
-
-  def setting_rawr_federated
-    settings.rawr_federated || false
-  end
-
-  def setting_hide_stats
-    settings.hide_stats || false
-  end
-
-  def setting_hide_captions
-    settings.hide_captions || false
-  end
-
   def allows_digest_emails?
     settings.notification_emails['digest']
   end