tycho: fix MapView sucking (and also remove RTTI)

master
an 2019-07-03 23:34:57 -04:00
parent f9722647af
commit 262ab3712e
6 changed files with 27 additions and 7 deletions

View File

@ -9,7 +9,11 @@ set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_AUTOUIC ON)
set(CMAKE_INCLUDE_CURRENT_DIR ON)
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Werror")
if(NOT MSVC)
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Werror")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti")
endif()
find_package(
Qt5 5.6.0

View File

@ -57,6 +57,7 @@
},
"IMapView": {
"type": "Object",
"baseClass": "IProjectView",
"functions": {
},
"properties": {

View File

@ -3,6 +3,7 @@
#pragma clang diagnostic ignored "-Winconsistent-missing-override"
#include <QAbstractItemModel>
#include <QWidget>
class IProjectModel : public QAbstractItemModel
{
@ -31,10 +32,16 @@ signals:
void selected(std::uint16_t index);
};
class IProjectView
class IProjectView : public QObject
{
Q_OBJECT
public:
using QObject::QObject;
virtual ~IProjectView() {}
virtual QWidget *widget() = 0;
};
// EOF

View File

@ -1,10 +1,11 @@
#include "tycho.h"
MapView::MapView(Project *parent) :
QWidget(parent),
IMapView(parent),
m_internal(parent),
m_mapModel(parent->mapModel())
{
setupUi(this);
setupUi(&m_internal);
dbgPrintFunc();
}
@ -14,4 +15,9 @@ MapView::~MapView()
dbgPrintFunc();
}
QWidget *MapView::widget()
{
return &m_internal;
}
// EOF

View File

@ -30,7 +30,7 @@ Project::Project(Type type) :
setAttribute(Qt::WA_DeleteOnClose);
listView->setModel(m_model);
verticalLayout->insertWidget(0, dynamic_cast<QWidget *>(m_view));
verticalLayout->insertWidget(0, m_view->widget());
connect(listView,
SIGNAL(doubleClicked(QModelIndex const &)),

View File

@ -47,8 +47,7 @@ private:
QVariant data(const QModelIndex &index, int role) const override;
};
class MapView final : public QWidget,
public IProjectView,
class MapView final : public IMapView,
private Ui::MapView
{
Q_OBJECT
@ -57,7 +56,10 @@ public:
explicit MapView(Project *parent);
~MapView();
QWidget *widget();
private:
QWidget m_internal;
MapModel *const m_mapModel;
};